Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIORGS-391 - Settings for banking information #577

Merged
merged 28 commits into from
Nov 1, 2023
Merged

UIORGS-391 - Settings for banking information #577

merged 28 commits into from
Nov 1, 2023

Conversation

alisher-epam
Copy link
Contributor

@alisher-epam alisher-epam commented Oct 20, 2023 •
edited
Loading

Purpose

UIORGS-391 - Settings for banking information

Approach

Screen.Recording.2023-11-01.at.5.06.05.PM.mov

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

alisher-epam and others added 7 commits October 11, 2023 18:57
@alisher-epam
UIORGS-391: add initial routing config and components
2b8e839
@zburke @alisher-epam
UIORGS-404 bump optional plugins to compatible versions (#572)
04b922a 
Use plugins compatible with the requested version of stripes (v9).

Refs UIORGS-404
@alisher-epam
Release v5.0.0 (#573)
0c5efe6
@alisher-epam
UIORGS-383: add donor info for organization summary (#574)
cdcf2cf 
* UIORGS-383: add donor info for organization summary

* tests: fix failing tests

* tests: remove failing snapshots

* tests: generate snapshot tests

* tests: update snapshot tests

* improve: bump package.json, fix organizations summary layout, remove checkbox handler
@alisher-epam
feat: add CRUD for banking account types
4ca7e50
@alisher-epam
UIORGS-391: integrate with backend.
c05b8e2
@alisher-epam
Merge branch 'master' into UIORGS-391
5884302
@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

Jest Unit Test Statistics

    1 files  ±  0    69 suites  +5   2m 37s ⏱️ -32s
226 tests +11  226 ✔️ +11  0 💤 ±0  0 ❌ ±0 
229 runs  +11  229 ✔️ +11  0 💤 ±0  0 ❌ ±0 

Results for commit 8e0010c. ± Comparison against base commit 06817ed.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 8e0010c. ± Comparison against base commit 06817ed.

♻️ This comment has been updated with latest results.

@alisher-epam alisher-epam requested review from a team October 23, 2023 07:36
usavkov-epam
usavkov-epam reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@usavkov-epam usavkov-epam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update package.json with the new okapi interfaces and required permissions for new endpoints.

usavkov-epam
usavkov-epam reviewed Oct 26, 2023
View reviewed changes
Copy link
Contributor

@usavkov-epam usavkov-epam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the comments below, note that there are no changes to the CHANGELOG.md file.

src/Settings/BankingAccountTypeSettings/BankingAccountTypeSettings.js Show resolved Hide resolved
src/Settings/BankingAccountTypeSettings/BankingAccountTypeSettings.js Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/Settings/BankingInformationSettings/BankingInformationSettings.js Show resolved Hide resolved
src/Settings/BankingInformationSettings/BankingInformationSettings.js Outdated Show resolved Hide resolved
src/Settings/BankingInformationSettings/BankingInformationSettings.js Outdated Show resolved Hide resolved
src/Settings/constants.js Outdated Show resolved Hide resolved
src/Settings/constants.js Outdated Show resolved Hide resolved
usavkov-epam
usavkov-epam reviewed Oct 27, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
NikitaSedyx
NikitaSedyx reviewed Oct 28, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
usavkov-epam
usavkov-epam reviewed Oct 30, 2023
View reviewed changes
src/Settings/BankingInformationSettings/BankingInformationSettings.test.js Show resolved Hide resolved
src/Settings/BankingInformationSettings/BankingInformationSettingsForm.js Outdated
label={<FormattedMessage id="ui-organizations.settings.bankingInformation" />}
name="value"
type="checkbox"
vertical
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think to be consistent we should keep label and checkbox horizontally:
https://folio-snapshot.dev.folio.org/settings/orders/approvals
https://folio-snapshot.dev.folio.org/settings/orders/open-order
https://folio-snapshot.dev.folio.org/settings/orders/instance-matching
https://folio-snapshot.dev.folio.org/settings/invoice/approvals
...

src/Settings/BankingInformationSettings/BankingInformationSettingsForm.test.js Show resolved Hide resolved
src/Settings/constants.js Outdated
export const SETTINGS_API = 'organizations-storage/settings';
export const BANKING_ACCOUNT_TYPES_API = 'organizations-storage/banking-account-types';

export const BANKING_INFORMATION_ENABLED_QUERY_KEY = 'key=BANKING_INFORMATION_ENABLED';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you keep BANKING_INFORMATION_ENABLED value as a separate const, please?

@alisher-epam alisher-epam requested review from usavkov-epam and a team October 31, 2023 15:31
usavkov-epam
usavkov-epam reviewed Nov 1, 2023
View reviewed changes
src/Settings/BankingAccountTypeSettings/BankingAccountTypeSettings.js Outdated
const ConnectedComponent = stripes.connect(ControlledVocab);

const columnMapping = {
value: <FormattedMessage id="ui-organizations.settings.name" />,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value or name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

usavkov-epam
usavkov-epam reviewed Nov 1, 2023
View reviewed changes
src/Settings/BankingInformationSettings/BankingInformationSettings.js Outdated
} catch (error) {
sendCallout({
type: 'error',
message: <FormattedMessage id="settings.accountTypes.save.error.generic.message" />,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app prefix in the label ID

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and please test if it works correctly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

usavkov-epam
usavkov-epam reviewed Nov 1, 2023
View reviewed changes
src/Settings/constants.js Outdated
export const BANKING_ACCOUNT_TYPES_API = 'organizations-storage/banking-account-types';

export const BANKING_INFORMATION_ENABLED_QUERY_KEY = 'BANKING_INFORMATION_ENABLED';
export const BANKING_INFORMATION_SEARCH_QUERY = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like search "params" is more appropriate for the const than "query"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.8% 83.8% Coverage
0.0% 0.0% Duplication

@alisher-epam alisher-epam merged commit 797cca8 into master Nov 1, 2023
@alisher-epam alisher-epam deleted the UIORGS-391 branch November 1, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usavkov-epam usavkov-epam usavkov-epam approved these changes

@OleksandrHladchenko1 OleksandrHladchenko1 OleksandrHladchenko1 approved these changes

@NikitaSedyx NikitaSedyx Awaiting requested review from NikitaSedyx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alisher-epam @NikitaSedyx @OleksandrHladchenko1 @usavkov-epam @zburke